fix(cli): rename bin entry from lingo.dev to lingo for Windows 11 compatibility #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxprilutskiy
approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows 11 compatibility issues by renaming the CLI command from lingo.dev to lingo and improving glob package imports for better cross-platform support.
Changes:
- Renamed bin entry from
lingo.devtolingoin package.json to resolve Windows 11 shell script path issues - Changed glob imports from named imports to namespace imports for better compatibility
- Fixed code formatting inconsistencies in bucket path pattern matching
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/package.json | Updated bin entry from lingo.dev to lingo for Windows 11 compatibility |
| packages/cli/src/cli/utils/find-locale-paths.ts | Changed glob import to namespace import and fixed empty catch block formatting |
| packages/cli/src/cli/utils/find-locale-paths.spec.ts | Updated test file to match new glob import pattern |
| packages/cli/src/cli/utils/buckets.ts | Changed glob import to namespace import and reformatted regexp string concatenation |
| packages/cli/src/cli/utils/buckets.spec.ts | Updated test file to use namespace import for glob |
| packages/cli/src/cli/utils/ensure-patterns.ts | Removed unused glob import |
| packages/cli/tsup.config.ts | Added "glob" to external dependencies list |
| .changeset/cute-icons-write.md | Added changeset documenting the CLI command fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| resolveLocaleCode(locale as LocaleCode); | ||
| return { locale, file }; | ||
| } catch (e) {} | ||
| } catch (e) { } |
There was a problem hiding this comment.
Empty catch block silently swallows errors. Consider logging the error or adding a comment explaining why it's safe to ignore exceptions here.
Suggested change
| } catch (e) { } | |
| } catch (e) { | |
| // Intentionally ignore invalid locale candidates and try the next one. | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix CLI command script for Windows 11 compatibility by renaming command from
lingo.devtolingo, which resolves shell script path issues and improves bucket path resolutionChanges
lingo.devtolingoin package.json bin field to fix Windows 11 execution issue and shell script path referencesTesting
Business logic tests added:
npx lingocommand works on Windows 11 (fixes issue 🐞 [BUG REPORT] ~ Issue withnpx lingo.devcommand is not working on Windows 11 #1521)lingo.dev/bin/cli.mjspath (fixes issue correct code #1606)Visuals
Required for UI/UX changes:
Checklist
Closes #1521
Closes #1606