Add functionality to the QueueView / SetView. #5107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
QueueViewhasfront/delete_frontwhile we may want to have apop.The
SetViewalso has thecontains/remove, and we may want to do both at once.Proposal
Implement a
.pop()forQueueView. Implement aremove_if_presentforSetView.Unfortunately, the
frontis not systematically followed by adelete_front. So, we cannot use it in the code.For the
SetViewchange, another PR indicates a different direction: Altogether removal of the unskippable entries.Test Plan
CI. Unit tests have been added.
Release Plan
Not that important. Could be
Links
None.