-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Provide access to consumed resources in integration tests #3781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jvff
wants to merge
15
commits into
linera-io:main
Choose a base branch
from
jvff:provide-access-to-consumed-resources-in-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Provide access to consumed resources in integration tests #3781
jvff
wants to merge
15
commits into
linera-io:main
from
jvff:provide-access-to-consumed-resources-in-tests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to propagate the consumed resources back to integration tests using the SDK.
Prepare to propagate the consumed resources back to integration tests using the SDK.
Prepare to propagate the consumed resources back to integration tests using the SDK.
Prepare to propagate the consumed resources back to integration tests using the SDK.
Prepare to propagate the consumed resources back to integration tests using the SDK.
Contains the certificate and the consumed resources.
Include the consumed resources with the certificate.
Use the new type so that the caller can check the consumed resources.
Use the new type for consistency.
Use the type returned by the `ActiveChain` methods that add a block.
Provide the same API used by some example integration tests.
Provide a similar API used by some example integration tests.
Remove the unnecessary `unwrap`s now that the API was tweaked.
A method to help writing assertions that a block used less resources than those provided by a grant.
3 tasks
…sumed-resources-in-tests
ed079b3
to
c7b1d31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Messages may be sent with resource grants so that the message receiver doesn't have to pay any fees to receive the message. However, figuring out how much resources to include in the grant is not trivial.
Proposal
Add support for writing integration tests asserting whether a block consumed less resources than those that would be provided by a grant.
Test Plan
TODO: this needs a test.
Release Plan
Links