Skip to content

Use newer Scylla driver crate version #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Use newer Scylla driver crate version #3772

merged 1 commit into from
May 13, 2025

Conversation

ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Apr 14, 2025 •
edited
Loading

Motivation

Same as #3789, the rust driver crate also needs to be updated

Proposal

Update crate and make things compile

Test Plan

CI + will deploy a network with this

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

@ndr-ds ndr-ds mentioned this pull request Apr 14, 2025
Closed
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Apr 14, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ndr-ds ndr-ds mentioned this pull request Apr 14, 2025
Closed
@ndr-ds ndr-ds force-pushed the 04-14-remove_allow_filtering_usage branch from 4c88f1a to 986934c Compare April 14, 2025 23:06
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 01d84ec to 251817b Compare April 14, 2025 23:06
@ndr-ds ndr-ds mentioned this pull request Apr 14, 2025
Closed
@ndr-ds ndr-ds force-pushed the 04-14-remove_allow_filtering_usage branch from 986934c to 8cd10f5 Compare April 16, 2025 22:24
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 251817b to 82dc328 Compare April 16, 2025 22:24
This was referenced Apr 16, 2025
Merged
Merged
@ndr-ds ndr-ds force-pushed the 04-14-remove_allow_filtering_usage branch from 8cd10f5 to 107c007 Compare April 16, 2025 22:42
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 82dc328 to 2b12d42 Compare April 16, 2025 22:42
@ndr-ds ndr-ds changed the base branch from 04-14-remove_allow_filtering_usage to graphite-base/3772 April 16, 2025 23:48
@ndr-ds ndr-ds force-pushed the graphite-base/3772 branch from 107c007 to d738461 Compare April 16, 2025 23:48
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 2b12d42 to 562d007 Compare April 16, 2025 23:48
@ndr-ds ndr-ds changed the base branch from graphite-base/3772 to 04-14-use_newer_scylladb_chart_versions April 16, 2025 23:48
@ndr-ds ndr-ds requested review from afck, ma2bd, MathieuDutSik and Twey April 17, 2025 02:14
@ndr-ds ndr-ds marked this pull request as ready for review April 17, 2025 02:15
@ndr-ds ndr-ds mentioned this pull request Apr 17, 2025
Merged
afck
afck approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @MathieuDutSik should take a look, too.

linera-views/src/backends/scylla_db.rs Outdated
@@ -694,15 +711,15 @@ impl AdminKeyValueStore for ScyllaDbStoreInternal {
Ok(result) => result,
Err(error) => {
let invalid_or_not_found = match &error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess this really means "invalid because [keyspace] not found"?)

@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 562d007 to 7c6bdc0 Compare May 2, 2025 19:48
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from d738461 to 46d022f Compare May 2, 2025 19:48
@ndr-ds ndr-ds mentioned this pull request May 2, 2025
Merged
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from 46d022f to 4600bd7 Compare May 2, 2025 20:05
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 7c6bdc0 to cf8f4ee Compare May 2, 2025 20:05
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from 4600bd7 to a1a65b3 Compare May 5, 2025 21:00
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from cf8f4ee to 01d34f3 Compare May 5, 2025 21:00
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from 985168a to a1a363c Compare May 6, 2025 02:43
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 250d3a4 to 9a220d5 Compare May 6, 2025 02:43
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from a1a363c to d5ae3b5 Compare May 6, 2025 14:51
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch 2 times, most recently from eb55bf3 to f1806fc Compare May 6, 2025 17:34
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from d5ae3b5 to bae30f4 Compare May 6, 2025 17:34
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from f1806fc to 4958525 Compare May 6, 2025 20:51
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch 2 times, most recently from d43ea8d to a0cd559 Compare May 6, 2025 22:17
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch 2 times, most recently from 1a3b61d to 82575aa Compare May 7, 2025 17:10
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from a0cd559 to 5c2b528 Compare May 7, 2025 17:10
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 82575aa to fa75aac Compare May 7, 2025 18:23
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch 2 times, most recently from 174664b to 737a670 Compare May 7, 2025 19:14
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from fa75aac to fc6a82b Compare May 7, 2025 19:15
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylladb_chart_versions branch from 737a670 to bb98c23 Compare May 9, 2025 16:57
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from fc6a82b to 5e22d5f Compare May 9, 2025 16:57
This was referenced May 9, 2025
Merged
Merged
@ndr-ds ndr-ds changed the base branch from 04-14-use_newer_scylladb_chart_versions to graphite-base/3772 May 9, 2025 21:39
@ndr-ds ndr-ds force-pushed the graphite-base/3772 branch from bb98c23 to b52eb31 Compare May 9, 2025 21:41
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 5e22d5f to 702c443 Compare May 9, 2025 21:41
@graphite-app graphite-app bot changed the base branch from graphite-base/3772 to main May 9, 2025 21:41
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 702c443 to 7435a15 Compare May 9, 2025 21:41
@ndr-ds ndr-ds force-pushed the 04-14-use_newer_scylla_driver_crate_version branch from 7435a15 to f746014 Compare May 13, 2025 15:39
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented May 13, 2025 •
edited
Loading

Merge activity

  • May 13, 1:02 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 13, 1:02 PM EDT: @ndr-ds merged this pull request with Graphite.

@ndr-ds ndr-ds merged commit aa79301 into main May 13, 2025
28 checks passed
@ndr-ds ndr-ds deleted the 04-14-use_newer_scylla_driver_crate_version branch May 13, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afck afck afck approved these changes

@ma2bd ma2bd Awaiting requested review from ma2bd

@MathieuDutSik MathieuDutSik Awaiting requested review from MathieuDutSik

@Twey Twey Awaiting requested review from Twey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndr-ds @afck