Nullable fields in AccessToken cause runtime crash#144
Open
PhuCG wants to merge 1 commit intoline:masterfrom
Open
Nullable fields in AccessToken cause runtime crash#144PhuCG wants to merge 1 commit intoline:masterfrom
PhuCG wants to merge 1 commit intoline:masterfrom
Conversation
…n, scopes, and tokenType; adjust tests accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AccessTokengetters declared non-nullable return types (String,num,List<String>), but values come from a rawMap<String, dynamic>. If any key is missing ornullin the server response, Dart throws a runtime exception when castingnullto a non-nullable type.Crash stack trace:
Root Cause
_data['token_type']returnsdynamic. At runtime, Dart implicitly casts it toString. If the value isnull, it throws immediately.Fix
Changed affected getters to return nullable types:
valueStringString?expiresInnumnum?scopesList<String>List<String>?tokenTypeStringString?Changes
lib/src/model/access_token.dart— updated getter return typestest/flutter_line_sdk_test.dart— updated assertions to use null-aware operators