Skip to content

Commit

Permalink
[Issue-5581] Change into transitive dependency(netty.transport.native…
Browse files Browse the repository at this point in the history
….unix.common) (#5623)

Motivation:

Explain why you're making this change and what problem you're trying to
solve.

Modifications:

From issue #5581, the class is exposed in the public API.
> Class io.netty.channel.unix.DomainSocketAddress is used as public
method parameter in
core/src/main/java/com/linecorp/armeria/common/util/DomainSocketAddress.java

Result:

- Closes #5581. (If this resolves the issue.)
- User can use [core]
com.linecorp.armeria.common.util.DomainSocketAddress#asNettyAddress
without adding dependency
  • Loading branch information
ChangguHan authored Apr 22, 2024
1 parent 6bbbfcf commit 9d9f843
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,12 @@ dependencies {

// Netty native libraries
['linux-x86_64', 'linux-aarch_64'].each { arch ->
implementation(variantOf(libs.netty.transport.native.unix.common) { classifier(arch) })
api(variantOf(libs.netty.transport.native.unix.common) { classifier(arch) })
implementation(variantOf(libs.netty.transport.native.epoll) { classifier(arch) })
optionalImplementation(variantOf(libs.netty.io.uring) { classifier(arch) })
}
['osx-x86_64', 'osx-aarch_64'].each { arch ->
implementation(variantOf(libs.netty.transport.native.unix.common) { classifier(arch) })
api(variantOf(libs.netty.transport.native.unix.common) { classifier(arch) })
implementation(variantOf(libs.netty.transport.native.kqueue) { classifier(arch) })
implementation(variantOf(libs.netty.resolver.dns.native.macos) { classifier(arch) })
}
Expand Down

0 comments on commit 9d9f843

Please sign in to comment.