Skip to content

Conversation

@camposandro
Copy link
Contributor

The missing keyword argument was detected by the hats-cloudtests smoke tests. Here is a successful run after the fix.

@camposandro camposandro requested a review from hombit November 6, 2025 15:57
@camposandro camposandro self-assigned this Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (cae486d) to head (fff6bee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files          19       19           
  Lines        2089     2089           
=======================================
  Hits         2032     2032           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Before [cae486d] After [107bd2e] Ratio Benchmark (Parameter)
211±100ms 130±70ms ~0.62 benchmarks.ReadFewColumnsHTTPS.time_run
1.30±0.01ms 1.35±0.02ms 1.03 benchmarks.NestedFrameReduce.time_run
175M 181M 1.03 benchmarks.ReadFewColumnsHTTPS.peakmem_run
65.7±0.9ms 66.5±0.5ms 1.01 benchmarks.CountNestedBy.time_run
255M 255M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
30.0±1ms 30.1±1ms 1.00 benchmarks.AssignSingleDfToNestedSeries.time_run
136M 136M 1.00 benchmarks.CountNestedBy.peakmem_run
1.33G 1.33G 1.00 benchmarks.ReadFewColumnsS3.peakmem_run
11.4±0.2ms 11.3±0.06ms 0.99 benchmarks.NestedFrameQuery.time_run
260M 259M 0.99 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

@camposandro camposandro merged commit d82a63d into main Nov 6, 2025
12 checks passed
@camposandro camposandro deleted the sandro/smoke-cloudtests branch November 6, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants