Skip to content

Conversation

@hombit
Copy link
Collaborator

@hombit hombit commented Sep 10, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 87.29508% with 31 lines in your changes missing coverage. Please review.

Project coverage is 91.04%. Comparing base (41b0a72) to head (56bc9b8).

Files with missing lines Patch % Lines
src/healpix_geometry_analysis/geometry/base.py 80.51% 15 Missing ⚠️
src/healpix_geometry_analysis/coordinates.py 85.36% 6 Missing ⚠️
...healpix_geometry_analysis/geometry/intermediate.py 89.47% 4 Missing ⚠️
src/healpix_geometry_analysis/geometry/polar.py 88.23% 4 Missing ⚠️
...c/healpix_geometry_analysis/geometry/equatorial.py 93.54% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   88.88%   91.04%   +2.15%     
==========================================
  Files           7       11       +4     
  Lines         243      402     +159     
==========================================
+ Hits          216      366     +150     
- Misses         27       36       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit marked this pull request as ready for review May 9, 2025 14:54
@hombit hombit requested a review from smcguire-cmu May 9, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants