Skip to content

TW-2574: Pause/Resume audio #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2025
Merged

TW-2574: Pause/Resume audio #2575

merged 5 commits into from
Oct 16, 2025

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Oct 1, 2025 •
edited
Loading

Ticket

Related issue

Pre-merge

Does anything else need to be done before merging?

linagora/social_media_recorder#6

Resolved

Attach screenshots or videos demonstrating the changes

ScreenRecording_10-02-2025.10-33-10_1.MP4

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2575

hoangdat
hoangdat reviewed Oct 8, 2025
View reviewed changes
@hoangdat
Copy link
Member

hoangdat commented Oct 10, 2025 •
edited by nqhhdev
Loading

  • should stop playing audio when do any actions

Reproduce

  1. Record audio
  2. Lock
  3. Pause
  4. Play to the middle of audio
  5. Send
  6. The player still play the audio

@hoangdat
Copy link
Member

hoangdat commented Oct 10, 2025 •
edited by nqhhdev
Loading

  • should add ripple to pause button

@hoangdat
Copy link
Member

hoangdat commented Oct 10, 2025 •
edited by nqhhdev
Loading

  • when audio in pause, still typing in the composer (???)

@hoangdat
Copy link
Member

hoangdat commented Oct 10, 2025 •
edited by nqhhdev
Loading

  • style of pause button not correct: size, border, ....

@hoangdat
Copy link
Member

  • should pause audio whenever have interruption: user click on back, phone call, ...

@nqhhdev nqhhdev force-pushed the TW-2574-mobile-pause-resume-audio branch from 194a19c to 82fcd42 Compare October 13, 2025 08:57
@nqhhdev nqhhdev force-pushed the TW-2574-mobile-pause-resume-audio branch from 34a01a4 to f22ee29 Compare October 14, 2025 10:29
@hoangdat hoangdat changed the base branch from main to oct_sprint October 14, 2025 10:33
@nqhhdev nqhhdev force-pushed the TW-2574-mobile-pause-resume-audio branch from f22ee29 to 978e69b Compare October 14, 2025 10:38
@nqhhdev nqhhdev force-pushed the TW-2574-mobile-pause-resume-audio branch from 978e69b to 198f06e Compare October 14, 2025 10:39
@hoangdat
Copy link
Member

hoangdat commented Oct 15, 2025 •
edited by nqhhdev
Loading

  • lost wave in message bubble

@hoangdat
Copy link
Member

hoangdat commented Oct 15, 2025 •
edited by nqhhdev
Loading

  • lost send button after deleting pause audio
Screen_Recording_20251015_223158.mp4

hoangdat
hoangdat reviewed Oct 15, 2025
View reviewed changes
hoangdat
hoangdat reviewed Oct 15, 2025
View reviewed changes
@hoangdat
Copy link
Member

  • merged 7652c30, please update and rebase

@nqhhdev nqhhdev force-pushed the TW-2574-mobile-pause-resume-audio branch from 4ae9a60 to 906eb59 Compare October 16, 2025 02:10
@hoangdat hoangdat merged commit 612a345 into oct_sprint Oct 16, 2025
2 of 3 checks passed
@hoangdat hoangdat deleted the TW-2574-mobile-pause-resume-audio branch October 16, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nqhhdev @hoangdat