fix the bugs#3958
Conversation
|
done |
|
hi @Monther-debug , can you describe your PR? |
|
I just fix the packages problem |
dab246
left a comment
dab246
left a comment
There was a problem hiding this comment.
We don't need this change. It's probably only needed on your project's side.
|
ok i will do it |
|
done |
1 similar comment
|
done |
|
Thanks a lot for this contribution. This PR has a title Which bugs? Can we have an exhaustive list of bugs fixed? Can we have 1 commit per bugs? Finally this pull request is not reviewable. The changeset is too huge. I believe this work needs serious rework and especially be split in explicit subparts (pull requests) so that we have a decent chance to review the quality of it and ensure it is safe. 
=> this is not ok Thanks for your understanding. |
| @@ -0,0 +1,28 @@ | |||
| C/C++ Structured Logr | |||
There was a problem hiding this comment.
I am reluctant to commit binaries from external sources.
| cupertino_icons: 1.0.6 | ||
|
|
||
| flutter_svg: 2.1.0 | ||
| flutter_svg: ^2.1.0 |
There was a problem hiding this comment.
Please use strict version. Having tolerance here open a vulnerability to potential suply chain attacks.
|
Thanks again for the contribution! This pull request is inactive for over 6 month. It is very complex with numerous commits and huge diff change, the team will not be able to integrate it as is. Thus, I will close it for now. If this is still relevant we can welcome those changes in new pull requests, but they would need to be focussed on a signle topic, with a reasonable amount of code change and commits that allow for a review, testing and improvments. Best regards, Benoit TELLIER |
4 participants
No description provided.