-
Notifications
You must be signed in to change notification settings - Fork 98
TF-3911 Support keyboard shortcuts accessibility on web #3910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dab246
wants to merge
9
commits into
master
Choose a base branch
from
enhancement/support-shortcuts-accessibility-on-web
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4aad2ea
TF-3911 Support mail keyboard shortcut actions in email detailed view…
dab246 584b729
TF-3911 Support mail keyboard shortcut actions in email list view on web
dab246 124e8c9
TF-3911 Support keyboard shortcut actions `ESC` to unfocus search in…
dab246 63e0fe9
TF-3911 Support keyboard shortcut actions `ESC` to close composer on…
dab246 989f818
TF-3911 Support mail keyboard shortcut actions in email searched list…
dab246 15241ab
TF-3911 Support mail keyboard shortcut actions in email searched list…
dab246 68ac753
TF-3911 Support keyboard shortcut actions `ESC` to close multiple com…
dab246 a626538
TF-3911 Remove window event listeners to prevent memory leaks in Emai…
dab246 4b53eb0
TF-3911 Add Keyboard shortcuts dictionary in Setting
dab246 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import 'package:equatable/equatable.dart'; | ||
|
|
||
| class KeyShortcut with EquatableMixin{ | ||
| final String key; | ||
| final String code; | ||
| final bool shift; | ||
|
|
||
| KeyShortcut({ | ||
| required this.key, | ||
| required this.code, | ||
| this.shift = false, | ||
| }); | ||
|
|
||
| bool matches(String expectedKey, {bool shift = false}) { | ||
| return key.toLowerCase() == expectedKey.toLowerCase() && | ||
| this.shift == shift; | ||
| } | ||
|
|
||
| @override | ||
| List<Object?> get props => [key, code, shift]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import 'package:flutter/services.dart'; | ||
|
|
||
| extension LogicalKeySetHelper on Set<LogicalKeyboardKey> { | ||
| bool isKey(LogicalKeyboardKey key) => contains(key); | ||
|
|
||
| bool isOnly(LogicalKeyboardKey key) => length == 1 && contains(key); | ||
|
|
||
| bool isShift() => | ||
| contains(LogicalKeyboardKey.shiftLeft) || | ||
| contains(LogicalKeyboardKey.shiftRight); | ||
|
|
||
| bool isShiftPlus(LogicalKeyboardKey key) => isShift() && contains(key); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.