Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3548 Handle exceeded quota #3557

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tddang-linagora
Copy link
Contributor

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3557.

Comment on lines 19 to 21
if (used == null || hardLimit == null || !isHardLimitReached) return '';

return filesize((used!.value - hardLimit!.value));
Copy link
Member

@dab246 dab246 Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It seems incorrect. Let's see the old logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dab246
Copy link
Member

dab246 commented Mar 17, 2025

  • Check quotas banner on mobile

@tddang-linagora
Copy link
Contributor Author

Check quotas banner on mobile

Screenshot_1742194759

@tddang-linagora tddang-linagora requested a review from dab246 March 17, 2025 07:00
@hoangdat
Copy link
Member

hoangdat commented Mar 17, 2025

  • transparent background of reload quota button
  • should keep quota information
Out of Storage
% of % Used

@tddang-linagora
Copy link
Contributor Author

transparent background of reload quota button
should keep quota information

Done

Screenshot 2025-03-17 at 15 42 58

Comment on lines +18 to +23
String get exceeded {
if (!isHardLimitReached) return '';

return filesize((used!.value - presentationHardLimit!.value));
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in use

Comment on lines +3215 to +3224
"quotaExceedAmount": "{amount} exceeded",
"@quotaExceedAmount": {
"type": "text",
"placeholders_order": [
"amount"
],
"placeholders": {
"amount": {}
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in use

Comment on lines +3305 to +3312
String quotaExceedAmount(String amount) {
return Intl.message(
'$amount exceeded',
name: 'quotaExceedAmount',
args: [amount],
);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants