Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3455 Add applicative token login method #3527

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tddang-linagora
Copy link
Contributor

Copy link

github-actions bot commented Mar 3, 2025

This PR has been deployed to https://linagora.github.io/tmail-flutter/3527.

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Also update l10n

Comment on lines 73 to 91
Row(
children: [
Text(
widget.appLocalizations.applicativeToken,
style: const TextStyle(fontWeight: FontWeight.bold, fontSize: 16),
),
const SizedBox(width: 8),
Expanded(
child: TextFieldBuilder(
controller: controller,
focusNode: focusNode,
autoFocus: true,
onTextChange: widget.onChanged,
maxLines: 1,
decoration: TextInputDecorationBuilder().build(),
),
),
],
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful if the text is too long (multiple language) the token input field will be too small.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded added

chibenwa
chibenwa previously approved these changes Mar 3, 2025
@dab246
Copy link
Member

dab246 commented Mar 3, 2025

  • Remove toast error for this case

Screenshot 2025-03-03 at 15 40 24

  • Try logout & login

@tddang-linagora
Copy link
Contributor Author

Remove toast error for this case
Try logout & login

untitled.webm

@tddang-linagora tddang-linagora requested a review from dab246 March 3, 2025 09:44
@hoangdat
Copy link
Member

hoangdat commented Mar 4, 2025

  • please check the case of unable to discovery jmap.

@tddang-linagora
Copy link
Contributor Author

please check the case of unable to discovery jmap.

applicative_oidc_fail.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants