Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3487 Handle Twake Mail errors #3504

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

TF-3487 Handle Twake Mail errors #3504

wants to merge 10 commits into from

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Feb 21, 2025 •
edited
Loading

Issue

Case handled

  • Open email to view fail
  • Search email result fail
  • Get mailbox fail

Demo

Updating

@tddang-linagora tddang-linagora self-assigned this Feb 21, 2025
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3504.

dab246
dab246 reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should find a way to handle errors more centrally, not handle the same error in more than one place, it will be difficult to manage later.

@tddang-linagora tddang-linagora force-pushed the enhancement/TF-3487-error-management branch from b67dfc3 to f758f54 Compare February 24, 2025 03:39
@tddang-linagora tddang-linagora marked this pull request as ready for review February 24, 2025 03:40
@dab246
Copy link
Member

dab246 commented Feb 28, 2025 •
edited by tddang-linagora
Loading

  • Write unit or integration test?

dab246
dab246 reviewed Feb 28, 2025
View reviewed changes
lib/features/mailbox/domain/usecases/get_all_mailbox_interactor.dart
Comment on lines +28 to +31
yield Left<Failure, Success>(GetAllMailboxFailure(
e,
onRetry: execute(session, accountId, properties: properties),
));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It not work when JMAP server use Mailbox/get method throw exception
Screen.Recording.2025-02-28.at.12.01.18.online-video-cutter.com.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception rethrowed at repository level.

@dab246
Copy link
Member

dab246 commented Feb 28, 2025 •
edited by tddang-linagora
Loading

  • There is no way to hide toast when searching/open mail for errors
Screen.Recording.2025-02-28.at.12.40.32.mov

@tddang-linagora
Copy link
Contributor Author

There is no way to hide toast when searching/open mail for errors

Screenshot 2025-03-04 at 11 02 02

Universal close icon added

@tddang-linagora tddang-linagora requested a review from dab246 March 4, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat Awaiting requested review from hoangdat

@dab246 dab246 Awaiting requested review from dab246

At least 2 approving reviews are required to merge this pull request.

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tddang-linagora @dab246