Skip to content

refactor: Remove redundant check for length #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor: Remove redundant check for length #2838

merged 1 commit into from
Nov 4, 2024

Conversation

@alexandear
Copy link
Member

@alexandear alexandear commented Nov 4, 2024

The PR refactors the code by removing redundant if len(slice) checks before iterating over the entire slice. for loops over an empty slice do nothing.

jandubois
jandubois approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 9889da7 into lima-vm:master Nov 4, 2024
29 checks passed
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Nov 4, 2024
@alexandear alexandear deleted the refactor/remove-redundant-if-len branch November 4, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandubois jandubois jandubois approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear @jandubois @AkihiroSuda