Skip to content

Commit

Permalink
[#noissue] Remove unused api
Browse files Browse the repository at this point in the history
 - Remove TraceContext#currentRpcTraceObject API
  • Loading branch information
emeroad committed Jun 5, 2017
1 parent b4b2465 commit 3bec16f
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 53 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ public Trace currentTraceObject() {
return traceFactory.currentTraceObject();
}

public Trace currentRpcTraceObject() {
return traceFactory.currentTraceObject();
}

/**
* Return trace without sampling check.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,20 +63,6 @@ public Trace currentTraceObject() {
return null;
}

/**
* Return Trace object without validating
*
* @return
*/
@Override
public Trace currentRpcTraceObject() {
final Trace trace = threadLocalBinder.get();
if (trace == null) {
return null;
}
return trace;
}

@Override
public Trace currentRawTraceObject() {
return threadLocalBinder.get();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ public interface TraceFactory extends BaseTraceFactory {

Trace currentTraceObject();

Trace currentRpcTraceObject();

Trace currentRawTraceObject();

Trace removeTraceObject();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ public Trace currentTraceObject() {
return this.delegate.currentTraceObject();
}

@Override
public Trace currentRpcTraceObject() {
return this.delegate.currentRpcTraceObject();
}

@Override
public Trace currentRawTraceObject() {
return this.delegate.currentRawTraceObject();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,6 @@ public void nullTraceObject() {
Trace rawTraceObject = traceFactory.currentRawTraceObject();
Assert.assertNull(rawTraceObject);

Trace rpcTraceObject = traceFactory.currentRpcTraceObject();
Assert.assertNull(rpcTraceObject);

traceFactory.newTraceObject();
Assert.assertNotNull(traceFactory.currentRawTraceObject());
}
Expand Down Expand Up @@ -96,27 +93,7 @@ public void testCurrentTraceObject_unsampled() throws Exception {
Assert.assertNotEquals(newTrace, currentTrace);
}

@Test
public void testCurrentRpcTraceObject() throws Exception {
TraceFactory traceFactory = sampledTraceFactory;

Trace trace = traceFactory.newTraceObject();
Trace rpcTraceObject = traceFactory.currentRpcTraceObject();

Assert.assertNotNull(rpcTraceObject);
Assert.assertSame(trace, rpcTraceObject);
}

@Test
public void testCurrentRpcTraceObject_unsampled() throws Exception {
TraceFactory traceFactory = unsampledTraceFactory;

Trace trace = traceFactory.newTraceObject();
Trace rpcTraceObject = traceFactory.currentRpcTraceObject();

Assert.assertNotNull(rpcTraceObject);
Assert.assertSame(trace, rpcTraceObject);
}

@Test
public void testCurrentRawTraceObject() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ public Trace currentTraceObject() {
return delegate.currentTraceObject();
}

@Override
public Trace currentRpcTraceObject() {
return delegate.currentRpcTraceObject();
}

@Override
public Trace currentRawTraceObject() {
return delegate.currentRawTraceObject();
Expand Down

0 comments on commit 3bec16f

Please sign in to comment.