Skip to content

Commit

Permalink
[NO-ISSUE] edit toString method to use StringBuilder
Browse files Browse the repository at this point in the history
  • Loading branch information
minwoo-jung committed Dec 19, 2016
1 parent 005660d commit 15413aa
Show file tree
Hide file tree
Showing 25 changed files with 228 additions and 156 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ public TCmdActiveThreadCountRes getActiveThreadCount() {
}

@Override
public String toString() {
return "AgentActiveThreadCount{" +
"agentId='" + agentId + '\'' +
", code=" + getCode() +
", codeMessage=" + getCodeMessage() +
", activeThreadCount=" + activeThreadCount +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("AgentActiveThreadCount{");
sb.append("agentId='").append(agentId).append('\'');
sb.append(", code=").append(code);
sb.append(", codeMessage='").append(codeMessage).append('\'');
sb.append(", activeThreadCount=").append(activeThreadCount);
sb.append('}');
return sb.toString();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ public int compare(AgentActiveThreadCount o1, AgentActiveThreadCount o2) {
return agentActiveThreadRepository;
}


@Override
public String toString() {
return "AgentActiveThreadCountList{" +
"agentActiveThreadRepository=" + agentActiveThreadRepository +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("AgentActiveThreadCountList{");
sb.append("agentActiveThreadRepository=").append(agentActiveThreadRepository);
sb.append('}');
return sb.toString();
}
}

Expand Down
17 changes: 12 additions & 5 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/AgentEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,17 @@ public boolean equals(Object obj) {
return true;
}

@Override
public String toString() {
return "AgentEvent [agentId=" + agentId + ", eventTimestamp=" + eventTimestamp + ", eventTypeCode="
+ eventTypeCode + ", eventTypeDesc=" + eventTypeDesc + ", hasEventMessage=" + hasEventMessage
+ ", eventMessage=" + eventMessage + ", startTimestamp=" + startTimestamp + "]";
@java.lang.Override
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("AgentEvent{");
sb.append("agentId='").append(agentId).append('\'');
sb.append(", eventTimestamp=").append(eventTimestamp);
sb.append(", eventTypeCode=").append(eventTypeCode);
sb.append(", eventTypeDesc='").append(eventTypeDesc).append('\'');
sb.append(", hasEventMessage=").append(hasEventMessage);
sb.append(", startTimestamp=").append(startTimestamp);
sb.append(", eventMessage=").append(eventMessage);
sb.append('}');
return sb.toString();
}
}
25 changes: 18 additions & 7 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/AgentInfo.java
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,23 @@ public int hashCode() {
}

@Override
public String toString() {
return "AgentInfo [applicationName=" + applicationName + ", agentId=" + agentId + ", startTimestamp="
+ startTimestamp + ", hostName=" + hostName + ", ip=" + ip + ", ports=" + ports + ", serviceTypeCode="
+ serviceTypeCode + ", pid=" + pid + ", vmVersion=" + vmVersion + ", agentVersion=" + agentVersion
+ ", serverMetaData=" + serverMetaData + ", jvmInfo=" + jvmInfo + ", initialStartTimestamp=" + initialStartTimestamp
+ ", status=" + status + "]";
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("AgentInfo{");
sb.append("applicationName='").append(applicationName).append('\'');
sb.append(", agentId='").append(agentId).append('\'');
sb.append(", startTimestamp=").append(startTimestamp);
sb.append(", hostName='").append(hostName).append('\'');
sb.append(", ip='").append(ip).append('\'');
sb.append(", ports='").append(ports).append('\'');
sb.append(", serviceTypeCode=").append(serviceTypeCode);
sb.append(", pid=").append(pid);
sb.append(", vmVersion='").append(vmVersion).append('\'');
sb.append(", agentVersion='").append(agentVersion).append('\'');
sb.append(", serverMetaData=").append(serverMetaData);
sb.append(", jvmInfo=").append(jvmInfo);
sb.append(", initialStartTimestamp=").append(initialStartTimestamp);
sb.append(", status=").append(status);
sb.append('}');
return sb.toString();
}

}
29 changes: 19 additions & 10 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/AgentStat.java
Original file line number Diff line number Diff line change
Expand Up @@ -203,22 +203,31 @@ public void setActiveTraceCounts(Map<SlotType, Integer> activeTraceCounts) {
}

@Override
public String toString() {
StringBuilder sb = new StringBuilder("AgentStat [");
sb.append("agentId=" + agentId + ", timestamp=" + timestamp + ", collectInterval=" + collectInterval);
sb.append(", gcType=" + gcType + ", gcOldCount=" + gcOldCount + ", gcOldTime=" + gcOldTime);
sb.append(", heapUsed=" + heapUsed + ", heapMax=" + heapMax + ", nonHeapUsed=" + nonHeapUsed);
sb.append(", nonHeapMax=" + nonHeapMax + ", jvmCpuUsage=" + jvmCpuUsage + ", systemCpuUsage=" + systemCpuUsage);
sb.append(", sampledNewCount=" + sampledNewCount + ", sampledContinuationCount=" + sampledContinuationCount);
sb.append(", unsampledNewCount=" + unsampledNewCount + ", unsampledContinuationCount=" + unsampledContinuationCount);
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("AgentStat{");
sb.append("agentId='").append(agentId).append('\'');
sb.append(", timestamp=").append(timestamp);
sb.append(", collectInterval=").append(collectInterval);
sb.append(", gcType='").append(gcType).append('\'');
sb.append(", gcOldCount=").append(gcOldCount);
sb.append(", gcOldTime=").append(gcOldTime);
sb.append(", heapUsed=").append(heapUsed);
sb.append(", heapMax=").append(heapMax);
sb.append(", nonHeapUsed=").append(nonHeapUsed);
sb.append(", nonHeapMax=").append(nonHeapMax);
sb.append(", jvmCpuUsage=").append(jvmCpuUsage);
sb.append(", systemCpuUsage=").append(systemCpuUsage);
sb.append(", sampledNewCount=").append(sampledNewCount);
sb.append(", sampledContinuationCount=").append(sampledContinuationCount);
sb.append(", unsampledNewCount=").append(unsampledNewCount);
sb.append(", unsampledContinuationCount=").append(unsampledContinuationCount);
if (histogramSchema != null) {
sb.append(", histogramSchemaTypeCode=" + histogramSchema.getTypeCode());
}
if (activeTraceCounts != null) {
sb.append(", activeTraceCounts=" + activeTraceCounts);
}
sb.append("]");
sb.append('}');
return sb.toString();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ public boolean equals(Object obj) {
}

@Override
public String toString() {
return "AgentStatus [agentId=" + agentId + ", eventTimestamp=" + eventTimestamp + ", state=" + state + "]";
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("AgentStatus{");
sb.append("agentId='").append(agentId).append('\'');
sb.append(", eventTimestamp=").append(eventTimestamp);
sb.append(", state=").append(state);
sb.append('}');
return sb.toString();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,17 @@ public void setDurationEndTimestamp(long durationEndTimestamp) {
}

@Override
public String toString() {
return "DurationalAgentEvent{" +
"agentId=" + super.getAgentId() +
", eventTimestamp=" + super.getEventTimestamp() +
", eventTypeCode=" + super.getEventTypeCode() +
", eventTypeDesc=" + super.getEventTypeDesc() +
", hasEventMessage=" + super.hasEventMessage() +
", eventMessage=" + super.getEventMessage() +
", startTimestamp=" + super.getStartTimestamp() +
", durationStartTimestamp=" + durationStartTimestamp +
", durationEndTimestamp=" + durationEndTimestamp +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("DurationalAgentEvent{");
sb.append("agentId=").append(super.getAGentid());
sb.append("eventTimestamp=").append(super.getEventTimestamp());
sb.append("eventTypeCode=").append(super.getEventTypeCode());
sb.append("eventTypeDesc=").append(super.getEventTypeDesc());
sb.append("hasEventMessage=").append(super.hasEventMessage());
sb.append("eventMessage=").append(super.getEventMessage());
sb.append("durationStartTimestamp=").append(durationStartTimestamp);
sb.append(", durationEndTimestamp=").append(durationEndTimestamp);
sb.append('}');
return sb.toString();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public void setLimitedTime(long limitedTime) {
}

@Override
public String toString() {
final StringBuilder sb = new StringBuilder("LimitedScanResult{");
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("LimitedScanResult{");
sb.append("limitedTime=").append(limitedTime);
sb.append(", data=").append(data);
sb.append('}');
Expand Down
18 changes: 10 additions & 8 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/LinkKey.java
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,15 @@ public int hashCode() {
return result;
}

@Override
public String toString() {
return "LinkKey{" +
"fromApplication='" + fromApplication + '\'' +
", fromServiceType=" + fromServiceType +
", toApplication='" + toApplication + '\'' +
", toServiceType=" + toServiceType +
'}';
@java.lang.Override
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("LinkKey{");
sb.append("fromApplication='").append(fromApplication).append('\'');
sb.append(", fromServiceType=").append(fromServiceType);
sb.append(", toApplication='").append(toApplication).append('\'');
sb.append(", toServiceType=").append(toServiceType);
sb.append(", hash=").append(hash);
sb.append('}');
return sb.toString();
}
}
14 changes: 12 additions & 2 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/LoadFactor.java
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,17 @@ public int getError() {
}

@Override
public String toString() {
return "LoadFactor [timeseriesValue=" + timeseriesValueList + ", timeseriesSlotIndex=" + timeseriesSlotIndex + ", range=" + range + ", successCount=" + successCount + ", failedCount=" + failedCount + "]";

@java.lang.Override
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("LoadFactor{");
sb.append(", timeseriesValueList=").append(timeseriesValueList);
sb.append(", timeseriesSlotIndex=").append(timeseriesSlotIndex);
sb.append(", range=").append(range);
sb.append(", successCount=").append(successCount);
sb.append(", failedCount=").append(failedCount);
sb.append(", timeWindow=").append(timeWindow);
sb.append('}');
return sb.toString();
}
}
25 changes: 13 additions & 12 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/Range.java
Original file line number Diff line number Diff line change
Expand Up @@ -96,20 +96,21 @@ public int hashCode() {
}

@Override
public String toString() {
return "Range{" +
"from=" + from +
", to=" + to +
", range=" + getRange() +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("Range{");
sb.append("from=").append(from);
sb.append(", to=").append(to);
sb.append(", range=").append(getRange());
sb.append('}');
return sb.toString();
}


public String prettyToString() {
return "Range{" +
"from=" + DateUtils.longToDateStr(from) +
", to=" + DateUtils.longToDateStr(to) +
", range s=" + TimeUnit.MILLISECONDS.toSeconds(getRange()) +
'}';
final java.lang.StringBuilder sb = new java.lang.StringBuilder("Range{");
sb.append("from=").append(from);
sb.append(", to=").append(to);
sb.append(", range s=").append(TimeUnit.MILLISECONDS.toSeconds(getRange()));
sb.append('}');
return sb.toString();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,13 @@ public Set<Map.Entry<String, TimeHistogram>> getAgentHistogram() {
}

@Override
public String toString() {
return "ResponseTime{" +
"applicationName='" + applicationName + '\'' +
", applicationServiceType=" + applicationServiceType +
", timeStamp=" + timeStamp +
", responseHistogramMap=" + responseHistogramMap +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("ResponseTime{");
sb.append("applicationName='").append(applicationName).append('\'');
sb.append(", applicationServiceType=").append(applicationServiceType);
sb.append(", timeStamp=").append(timeStamp);
sb.append(", responseHistogramMap=").append(responseHistogramMap);
sb.append('}');
return sb.toString();
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ public boolean equals(Object obj) {
}

@Override
public String toString() {
return "ResponseTimeRange [from=" + from + ", to=" + to + "]";
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("ResponseTimeRange{");
sb.append("from=").append(from);
sb.append(", to=").append(to);
sb.append('}');
return sb.toString();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ public boolean equals(Object obj) {
}

@Override
public String toString() {
return "SelectedScatterArea [timeRange=" + timeRange + ", responseTimeRange=" + responseTimeRange + "]";
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("SelectedScatterArea{");
sb.append("timeRange=").append(timeRange);
sb.append(", responseTimeRange=").append(responseTimeRange);
sb.append('}');
return sb.toString();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,13 @@ public int hashCode() {
}

@Override
public String toString() {
return "QueryCondition [transactionId=" + transactionId + ", collectorAcceptorTime=" + collectorAcceptorTime + ", responseTime=" + responseTime + "]";
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("QueryCondition{");
sb.append("transactionId=").append(transactionId);
sb.append(", collectorAcceptorTime=").append(collectorAcceptorTime);
sb.append(", responseTime=").append(responseTime);
sb.append('}');
return sb.toString();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ public int hashCode() {
}

@Override
public String toString() {
return "Chart{" +
"points=" + points +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("Chart{");
sb.append("points=").append(points);
sb.append('}');
return sb.toString();
}
}
15 changes: 8 additions & 7 deletions web/src/main/java/com/navercorp/pinpoint/web/vo/chart/Point.java
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,13 @@ public int hashCode() {
}

@Override
public String toString() {
return "Point{" +
"xVal=" + xVal +
", minYVal=" + minYVal +
", maxYVal=" + maxYVal +
", avgYVal=" + avgYVal +
'}';
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("Point{");
sb.append("xVal=").append(xVal);
sb.append(", minYVal=").append(minYVal);
sb.append(", maxYVal=").append(maxYVal);
sb.append(", avgYVal=").append(avgYVal);
sb.append('}');
return sb.toString();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,11 @@ public int hashCode() {
}

@Override
public String toString() {
return "TitledPoint{" +
"title='" + title + '\'' +
"} " + super.toString();
public java.lang.String toString() {
final java.lang.StringBuilder sb = new java.lang.StringBuilder("TitledPoint{");
sb.append("title='").append(title).append('\'');
sb.append('} ');
sb.append(super.toString());
return sb.toString();
}
}
Loading

0 comments on commit 15413aa

Please sign in to comment.