telemetry: the enforcement conversation key gets a shadow#2124
Merged
Conversation
The cost dashboards facet conversations by the observation conversation_id — which, per #2123, can pool same-opener conversations into one row (deliberately left as designed; observation and intervention are separate concerns now). The budget layer's own key is collision-resistant, and it was already computed on every request; this records its day-salted scope key into the request event, sibling to budget_source_id, so per-conversation cost views can facet on something that can't merge strangers. Nil when the conversation isn't yet seeded, same as enforcement. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mattsodomsky
added a commit
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-on to #2123. The cost dashboards facet conversations by the observation
conversation_id— which can pool same-opener conversations into one row (a known, deliberately-kept property of the observation ids; observation and intervention are separate concerns now). That's fine for Isaac's original observational purpose, but the cost dashboard needs per-conversation rows that can't merge strangers.The budget layer already computes a collision-resistant conversation key on every request; this just records its day-salted scope key into the request event as
budget_conversation_id, sibling to the existingbudget_source_id. Nil when the conversation isn't yet seeded, exactly mirroring enforcement. No behavior changes anywhere — one field added to telemetry.After this deploys, the dashboard's conversation-faceted cost widgets can move to the new field (day-scoped views, matching its day-salt), and deep multi-source "conversation" rows stop being ambiguous.
🤖 Generated with Claude Code