Fix falsy 0 check, use testing config everywhere #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyav
force-pushed
the
03-17-fix_falsy_0_check
branch
from
f8d4f39 to
41f6d8b
Compare
shreyav
changed the title
jklein24
reviewed
Mar 18, 2025
| @@ -472,7 +475,9 @@ def _handle_internal_uma_payreq( | |||
| ) | |||
|
|
|||
| print(f"payreq_response: {payreq_response.to_dict()}") | |||
| if uma_version == 1: | |||
| # Skip signature verification in testing mode to avoid needing to run 2 VASPs. | |||
There was a problem hiding this comment.
Can you remind me of the details on this one? Don't we already run 2 vasps in each test case? Where does this break down?
There was a problem hiding this comment.
this is unrelated to the tests! only line 524 is related
I added this for consistency because some of the signature validation steps use this config and some dont
There was a problem hiding this comment.
hmm... I totally don't remember why we need that 🤔
jklein24
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.