Use new error code standard in demo VASPs #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyav
force-pushed
the
02-26-use_new_error_code_standard_in_demo_vasps
branch
5 times, most recently
from
960ccce to
ab01b53
Compare
jklein24
reviewed
Feb 27, 2025
uma_vasp/__init__.py
Outdated
| def unsupported_version(e): | ||
| return jsonify(json.loads(e.to_json())), 412 | ||
| def handle_uma_exception(e): | ||
| return e.to_json(), e.to_http_status_code() |
There was a problem hiding this comment.
Will this do the right thing WRT content type?
There was a problem hiding this comment.
ahh great catch! confirmed its fixed after updating
shreyav
force-pushed
the
02-26-use_new_error_code_standard_in_demo_vasps
branch
from
ab01b53 to
de8ef80
Compare
shreyav
force-pushed
the
02-26-use_new_error_code_standard_in_demo_vasps
branch
from
de8ef80 to
bca5ca6
Compare
jklein24
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.