Added paymentHash and preimageNonce params to createInvoice functions #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklein24
reviewed
Mar 25, 2025
| @@ -134,8 +136,20 @@ class LightsparkFuturesClient(config: ClientConfig) { | |||
| memo: String? = null, | |||
| type: InvoiceType = InvoiceType.STANDARD, | |||
| expirySecs: Int? = null, | |||
| paymentHash: Hash32? = null, | |||
There was a problem hiding this comment.
Sorry I should have clarified - The graphql query types should be Hash32, but in kotlin, they should just be strings here.
There was a problem hiding this comment.
Updated to be strings in Kotlin but kept the types as Hash32 in the mutation string.
…urlInvoice, and createUmaInvoice and their respective mutations from all 3 clients.
AaryamanBhute
force-pushed
the
aaryaman/lpt-262-add-payment_has-and-preimage_nonce-parameters
branch
from
8e462af to
6009d01
Compare
AaryamanBhute
deleted the
aaryaman/lpt-262-add-payment_has-and-preimage_nonce-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added paymentHash and preimageNonce params to createInvoice, createLnurlInvoice, and createUmaInvoice and their respective mutations from all 3 clients.
Used type of Hash32 on both parameters in order to match mutation input object types like: