Skip to content

event-target: add a type field #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion include/dom/events/event_target.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,14 @@ struct dom_event;

struct listener_entry;

/* Event target is a mixin interface, thus has no concrete implementation.
/**
* Type of a DOM event_target
*/
typedef enum {
DOM_EVENT_TARGET_NODE = 1,
} dom_event_target_type;

/* Event target is a mixin interface, thus has no concrete implementation.
* Subclasses must provide implementations of the event target methods. */
typedef struct dom_event_target {
void *vtable;
Expand Down Expand Up @@ -51,6 +58,9 @@ typedef struct dom_event_target_vtable {
struct listener_entry *cur,
struct listener_entry **next,
struct dom_event_listener **listener);
dom_exception (*dom_event_target_get_type)(
dom_event_target *et,
dom_event_target_type *result);
} dom_event_target_vtable;

static inline dom_exception dom_event_target_add_event_listener(
Expand Down Expand Up @@ -132,5 +142,13 @@ static inline dom_exception dom_event_iter_event_listener(
(struct listener_entry *) (c), (struct listener_entry **) (n),\
(struct dom_event_listener **) (l))

static inline dom_exception dom_event_target_get_type(dom_event_target *et,
dom_event_target_type *result)
{
return ((dom_event_target_vtable *) et->vtable)
->dom_event_target_get_type(et, result);
}
#define dom_event_target_get_type(et, r) dom_event_target_get_type( \
(dom_event_target *) (et), (dom_event_target_type *) (r))
#endif

8 changes: 8 additions & 0 deletions src/core/node.c
Original file line number Diff line number Diff line change
Expand Up @@ -2645,3 +2645,11 @@ dom_exception _dom_node_iter_event_listener(dom_event_target *et,
return _dom_event_target_iter_event_listener(
node_internal->eti, type, capture, cur, next, listener);
}

dom_exception _dom_node_event_target_get_type(dom_event_target *et,
dom_event_target_type *result)
{
assert(et != NULL);
dom_node_internal *node_internal = (dom_node_internal *)et;
return _dom_event_target_get_type(node_internal->eti, result);
}
5 changes: 4 additions & 1 deletion src/core/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ dom_exception _dom_node_iter_event_listener(dom_event_target *et,
dom_string *type, bool capture,
struct listener_entry *cur, struct listener_entry **next,
struct dom_event_listener **listener);
dom_exception _dom_node_event_target_get_type(dom_event_target *et,
dom_event_target_type *result);

/* The DOM Node's vtable methods */
dom_exception _dom_node_get_node_name(dom_node_internal *node,
Expand Down Expand Up @@ -195,7 +197,8 @@ dom_exception _dom_node_get_user_data(const dom_node_internal *node,
_dom_node_dispatch_event, \
_dom_node_add_event_listener_ns, \
_dom_node_remove_event_listener_ns, \
_dom_node_iter_event_listener
_dom_node_iter_event_listener, \
_dom_node_event_target_get_type

#define DOM_NODE_VTABLE \
_dom_node_try_destroy, \
Expand Down
17 changes: 17 additions & 0 deletions src/events/event_target.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,3 +323,20 @@ dom_exception _dom_event_target_iter_event_listener(dom_event_target_internal et
}
return DOM_NO_ERR;
}

/**
* Retrieve the type of an event_target
*
* \param node The eti to retrieve the type of
* \param result Pointer to location to receive node type
* \return DOM_NO_ERR.
*/
dom_exception _dom_event_target_get_type(dom_event_target_internal eti,
dom_event_target_type *result)
{
UNUSED(eti);

*result = DOM_EVENT_TARGET_NODE;

return DOM_NO_ERR;
}
3 changes: 3 additions & 0 deletions src/events/event_target.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,7 @@ dom_exception _dom_event_target_iter_event_listener(dom_event_target_internal et
struct listener_entry *cur, struct listener_entry **next,
dom_event_listener **listener);

dom_exception _dom_event_target_get_type(dom_event_target_internal eti,
dom_event_target_type *result);

#endif
Loading