Implement effective request cancellation on notifications/cancelled#26
Open
salignatmoandal wants to merge 1 commit intolightpanda-io:mainfrom
Open
Implement effective request cancellation on notifications/cancelled#26salignatmoandal wants to merge 1 commit intolightpanda-io:mainfrom
salignatmoandal wants to merge 1 commit intolightpanda-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I came across a TODO in the codebase and went ahead and implemented it — hope that helps!###
Summary
This PR implements proper request cancellation in the MCP server. When a
notifications/cancelledmessage is received, the server now effectively cancels the corresponding in-flight request using Go's context cancellation mechanism.Details
cancelsmap and mutex toMCPServerto track cancellable contexts by request ID.ToolsCallRequest, a cancellable context is created and stored.notifications/cancelledmessage is received, the server looks up and calls the corresponding cancel function, stopping the ongoing task.Why
Previously, cancellation requests were only logged and had no effect. This change allows clients to actually interrupt long-running or unwanted operations, improving resource usage and responsiveness.
N/A
Let me know if you want a test scenario or further improvements!