lncfg: add deprecated no-experimental-endorsement config option

[ziggie1984]

Re-adds the old no-experimental-endorsement config option as a hidden,
deprecated alias for no-experimental-accountability. This ensures
backward compatibility for users who have the old option in their
config files after the rename it.

it was renamed here: #10367

[gemini-code-assist]

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses backward compatibility by reintroducing a previously renamed configuration option, no-experimental-endorsement, as a hidden and deprecated alias for no-experimental-accountability. This change ensures that existing user configurations continue to function without disruption, while clearly signaling the option's deprecation and planned removal.

Highlights

• Re-introduced Deprecated Option: The no-experimental-endorsement configuration option has been re-added to the protocol configuration.
• Alias for New Option: This re-added option functions as a hidden, deprecated alias for the no-experimental-accountability option.
• Backward Compatibility: The primary purpose of this change is to ensure backward compatibility for users who might still be using the old option in their configuration files.
• Future Removal: The no-experimental-endorsement option is explicitly marked as hidden and is slated for removal in a future release.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request re-introduces the no-experimental-endorsement configuration option as a hidden, deprecated alias for no-experimental-accountability. This change is for backward compatibility, ensuring that users with the old option in their configuration files do not experience breaking changes. The implementation is straightforward and correct, adding the deprecated field to the ProtocolOptions struct and updating the NoExpAccountability method to check for either option. The changes are correctly mirrored in both protocol.go and protocol_integration.go. The code is clean and adheres to the project's style guidelines. I have no specific comments as the changes are well-implemented.

[Roasbeef]

LGTM 🥕

[bitromortac]

LGTM 🎉

[github-actions]

Created backport PR for v0.20.x-branch:

• [v0.20.x-branch] Backport #10495: lncfg: add deprecated no-experimental-endorsement config option #10502 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10495-to-v0.20.x-branch
git worktree add --checkout .worktree/backport-10495-to-v0.20.x-branch backport-10495-to-v0.20.x-branch
cd .worktree/backport-10495-to-v0.20.x-branch
git reset --hard HEAD^
git cherry-pick -x 04dab619cb8e09024d59e11fce5af1d51acb1786
git push --force-with-lease