peer: fix log output when not applicable

[ziggie1984]

Before we would always log that the peer was not ready starting
up although it was not the case. We now make sure we still log
this case but only when applicable.

[gemini-code-assist]

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logging behavior within the peer disconnection process. It addresses an issue where a debug message about a peer's startup status was being logged indiscriminately. The change introduces more precise conditional logic to ensure this specific log message is only displayed when the peer is truly still initializing, thereby improving log clarity and diagnostic accuracy.

Highlights

• Logging Improvement: The pull request fixes an issue where a debug log message, indicating a peer was not ready during startup, was always printed upon disconnection, even if the peer had already completed its startup process.
• Conditional Logging Logic: A non-blocking select statement has been introduced to check the startReady signal. This ensures the 'peer not ready' log message is now only emitted when the peer is genuinely still in the startup phase, reducing unnecessary log noise.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where a log message about a peer not being ready was always displayed, even when the peer had already started. The change introduces a non-blocking check to see if the peer has finished starting up before logging the message, which is a sound approach. I've added a couple of minor style suggestions to align the code with the repository's style guide regarding spacing in select statements.

[lightninglabs-deploy]

@ziggie1984, remember to re-request review from reviewers when ready