Skip to content

Fix flaky watchtower and invoice tests #10464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gijswijs wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −5
Open

Fix flaky watchtower and invoice tests #10464

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8c69e
invoices: increase timeout parallel Postgres tests
gijswijs Dec 17, 2025
1bac155
wtclient: fix race conditions locking tests
gijswijs Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion invoices/test_utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ func timeout() func() {

go func() {
select {
case <-time.After(10 * time.Second):
// Use a longer timeout to accommodate slow Postgres database
// setup and migrations when running tests in parallel.
case <-time.After(60 * time.Second):
Copy link
Collaborator

@bhandras bhandras Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use named constant

err := pprof.Lookup("goroutine").WriteTo(os.Stdout, 1)
if err != nil {
panic(fmt.Sprintf("error writing to std out "+
Expand Down