Skip to content

ecies: add version byte prefix to encoding format #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Jun 25, 2025

Extend the encoding format to include a version byte prefix. This helps facilitate cleaner and safer upgrades in the future.

ffranr added 2 commits June 25, 2025 10:48
Extend the encoding format to include a version byte prefix.
This helps facilitate cleaner and safer upgrades in the future.
@ffranr ffranr requested a review from guggero June 25, 2025 10:10
@ffranr ffranr self-assigned this Jun 25, 2025
@ffranr ffranr added crypto version Issues which relate to data structure versioning labels Jun 25, 2025
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you! LGTM 🎉

The litd itest is going to be fixed by #1614, so we can ignore that here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15873552727

Details

  • 33 of 40 (82.5%) changed or added relevant lines in 1 file are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.08%) to 38.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/ecies/ecies.go 33 40 82.5%
Files with Coverage Reduction New Missed Lines %
internal/ecies/ecies.go 2 78.69%
tappsbt/create.go 2 26.74%
tapdb/multiverse.go 6 53.28%
tapgarden/caretaker.go 10 67.63%
Totals Coverage Status
Change from base Build 15865241809: 0.08%
Covered Lines: 29639
Relevant Lines: 76643

💛 - Coveralls

@ffranr ffranr requested a review from GeorgeTsagk June 25, 2025 11:59
@ffranr ffranr added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit d6d2c9b Jun 25, 2025
17 of 18 checks passed
@guggero guggero deleted the wip/ecies-version branch June 25, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto version Issues which relate to data structure versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants