-
Notifications
You must be signed in to change notification settings - Fork 132
[group key addrs 1/?]: add new authmailbox RPC server and client #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 15734766059Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @ffranr and @guggero)
I removed the sender's ephemeral key from the proto. It will be part of the encrypted payload, passed into the |
58df937
to
937db82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦋
Reviewed 12 of 12 files at r2, all commit messages.
Reviewable status: all files reviewed, 19 unresolved discussions (waiting on @ffranr and @guggero)
authmailbox/client.go
line 133 at r2 (raw file):
func (c *Client) Stop() error { var stopErr error c.stopOnce.Do(func() {
👍 for sync.Once
.
authmailbox/server.go
line 99 at r2 (raw file):
// Start signals that the RPC server starts accepting requests. func (s *Server) Start() error { if !s.started.CompareAndSwap(false, true) {
sync.Once
here again to be consistent with the rest of the PR?
To allow re-starting a server with a given listen address, we refactor some of the code to export a new function to do just that.
TxProof is a struct that holds all components to prove a claimed outpoint exists in a given block.
Implements the mailbox server and client as described here: #874 (comment)
This change is