Add protocol compliant PostgresKvStore impl. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
G8XSU
commented
Sep 30, 2024
•
G8XSU
commented
- Add protocol compliant PostgresKvStore impl.
G8XSU
force-pushed
the
rust-postgres
branch
4 times, most recently
from
a0196f6 to
2e82585
Compare
jkczyz
reviewed
Feb 4, 2025
Comment on lines
+218
to
+231
| } else if request.key == GLOBAL_VERSION_KEY { | ||
| KeyValue { key: GLOBAL_VERSION_KEY.to_string(), value: Bytes::new(), version: 0 } |
There was a problem hiding this comment.
Shouldn't we read this if it is written in put? The version in the database might not be 0, IIUC.
There was a problem hiding this comment.
If it is present, we first try to read it(this is the first if condition). If it is not present, then we default to 0 for global version.(this is handled by second if condition i.e. request.key == GLOBLAL_VERSION_KEY)
|
Added fixup commit with all fixups. |
jkczyz
approved these changes
Feb 6, 2025
jkczyz
reviewed
Feb 6, 2025
|
Squashed fixups! |
jkczyz
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.