Skip to content

Bump electrum-client to v0.24.0 #3991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Aug 7, 2025

We bump the electrum-client dependency to the recently-introduced version v0.24.0.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 7, 2025

👋 I see @joostjager was un-assigned.
If you'd like another reviewer assignment, please click here.

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (de2005a) to head (10b0ddb).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3991      +/-   ##
==========================================
+ Coverage   88.93%   88.94%   +0.01%     
==========================================
  Files         174      174              
  Lines      124539   124575      +36     
  Branches   124539   124575      +36     
==========================================
+ Hits       110758   110803      +45     
+ Misses      11287    11278       -9     
  Partials     2494     2494              
Flag Coverage Δ
fuzzing 22.18% <ø> (-0.01%) ⬇️
tests 88.77% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnull tnull requested review from valentinewallace and removed request for joostjager and valentinewallace August 7, 2025 12:28
@tnull tnull marked this pull request as draft August 7, 2025 13:09
@tnull
Copy link
Contributor Author

tnull commented Aug 7, 2025

Draft until we can upgrade electrsd, too. (See RCasatta/electrsd#104)

We bump the `electrum-client` dependency to the recently-introduced
version v0.24.0. We also bump `electrsd` to v0.35.0 and `corepc-node` to
v0.8.
@tnull tnull force-pushed the 2025-08-bump-electrum-client branch from 7d7270d to 10b0ddb Compare August 8, 2025 11:51
@tnull
Copy link
Contributor Author

tnull commented Aug 8, 2025

This seems to work now that electrsd shipped a new release.

@tnull tnull marked this pull request as ready for review August 8, 2025 13:07
@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@tnull tnull requested review from valentinewallace and removed request for joostjager August 11, 2025 07:39
@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@valentinewallace valentinewallace merged commit 83da6c3 into lightningdevkit:main Aug 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants