Make ChannelSigner solely responsible for validating commitment sigs
#3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the custom transactions project, we want to make channel generic over any funding, htlc, and revokeable scripts used on-chain. Hence, this commit removes the validation of holder commitment signatures from channel, as it requires building the funding, htlc, and revokeable scripts to create the expected sighash. This signature validation is now the sole responsibility of `ChannelSigner::validate_holder_commitment`. This commit updates `InMemorySigner` to honor this new API contract.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
tankyleo
commented
Jun 21, 2025
Comment on lines
765
to
769
| fn validate_holder_commitment( | ||
| &self, holder_tx: &HolderCommitmentTransaction, | ||
| outbound_htlc_preimages: Vec<PaymentPreimage>, | ||
| &self, channel_parameters: &ChannelTransactionParameters, | ||
| holder_tx: &HolderCommitmentTransaction, outbound_htlc_preimages: Vec<PaymentPreimage>, | ||
| secp_ctx: &Secp256k1<secp256k1::All>, | ||
| ) -> Result<(), ()>; |
There was a problem hiding this comment.
Do we add a logger here ? This would add a generic on the ChannelSigner trait as far as I see.
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the custom transactions project, we want to make channel generic over any funding, htlc, and revokeable scripts used on-chain.
Hence, this commit removes the validation of holder commitment signatures from channel, as it requires building the funding, htlc, and revokeable scripts to create the expected sighash.
This signature validation is now the sole responsibility of
ChannelSigner::validate_holder_commitment.This commit updates
InMemorySignerto honor this new API contract.