Don't enforce owned values be written in legacy TLV writing
#3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing legacy TLVs, we use a lambda that returns an `Option` over a specified type. To avoid implicit type confusion issues, we explicitly check that that lambda writes an `Option<Type>`. However, we may wish to occasionally write an `Option<&Type>` to avoid unnecessary allocations. Here we replace the explicit type confusion check with a verification by reading the written contents back explicitly using the specified Type. This should catch most cases of type confusion as we will generally end up writing a different number of bytes.
|
I've assigned @wpaulino as a reviewer! |
wpaulino
approved these changes
Mar 5, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
✅ Added second reviewer: @arik-so |
arik-so
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing legacy TLVs, we use a lambda that returns an
Optionover a specified type. To avoid implicit type confusion issues, we explicitly check that that lambda writes anOption<Type>. However, we may wish to occasionally write anOption<&Type>to avoid unnecessary allocations.Here we replace the explicit type confusion check with a verification by reading the written contents back explicitly using the specified Type. This should catch most cases of type confusion as we will generally end up writing a different number of bytes.