Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft][Splicing] Add reserve check to splicing #3641

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Mar 4, 2025

This is a continuation of #3407, adds proper channel balance/reserve check, when handling splice_ack (on initiator side).

@ldk-reviews-bot
Copy link

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@optout21
Copy link
Contributor Author

optout21 commented Mar 4, 2025

Relevant comments from #3407:

Relevant method: check_splice_balances_meet_v2_reserve_requirements

@optout21 optout21 force-pushed the splice-reserve-check branch from cd3c40b to e34d33c Compare March 4, 2025 16:42
@optout21 optout21 force-pushed the splice-reserve-check branch from e34d33c to 6ec1a19 Compare March 4, 2025 19:37
@optout21
Copy link
Contributor Author

optout21 commented Mar 4, 2025

Suggestions implemented; for reserve requirement check, the balance is adjusted with fees and eventual anchor output value (see 6ec1a19).
On hold, waiting for #3407 to land first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants