-
Notifications
You must be signed in to change notification settings - Fork 403
Peer Storage Feature – Part 2 #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
aece1f1
4f09dad
adfbc78
cc3a185
510c8bf
bd37f0e
1cdd004
ed58827
a199cc6
2ee15ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,186 @@ | ||
// This file is Copyright its original authors, visible in version control | ||
// history. | ||
// | ||
// This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE | ||
// or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option. | ||
// You may not use this file except in accordance with one or both of these | ||
// licenses. | ||
|
||
//! `OurPeerStorage` enables storage of encrypted serialized channel data. | ||
//! It provides encryption and decryption of data to maintain data integrity and | ||
//! security during transmission. | ||
//! | ||
|
||
use bitcoin::hashes::sha256::Hash as Sha256; | ||
use bitcoin::hashes::{Hash, HashEngine, Hmac, HmacEngine}; | ||
|
||
use crate::sign::PeerStorageKey; | ||
|
||
use crate::crypto::chacha20poly1305rfc::ChaCha20Poly1305RFC; | ||
use crate::prelude::*; | ||
|
||
/// [`OurPeerStorage`] is used to store encrypted channel information that allows for the creation of a | ||
/// `peer_storage` backup. | ||
/// | ||
/// This structure is designed to serialize channel data for backup and supports encryption | ||
/// and decryption using `ChaCha20Poly1305RFC` for transmission. | ||
/// | ||
/// # Key Methods | ||
/// - [`OurPeerStorage::new`]: Returns [`OurPeerStorage`] with the given encrypted_data. | ||
/// - [`OurPeerStorage::create_from_data`]: Returns [`OurPeerStorage`] created from encrypting the provided data. | ||
/// - [`OurPeerStorage::decrypt_our_peer_storage`]: Decrypts the [`OurPeerStorage::encrypted_data`] using the key and returns decrypted data. | ||
/// | ||
/// ## Example | ||
/// ``` | ||
/// use lightning::ln::our_peer_storage::OurPeerStorage; | ||
/// use lightning::sign::PeerStorageKey; | ||
/// let key = PeerStorageKey{inner: [0u8; 32]}; | ||
/// let decrypted_ops = OurPeerStorage::DecryptedPeerStorage { data: vec![1, 2, 3]}; | ||
/// let our_peer_storage = decrypted_ops.encrypt_peer_storage(&key, [0u8; 32]); | ||
/// let decrypted_data = our_peer_storage.decrypt_peer_storage(&key).unwrap(); | ||
/// assert_eq!(decrypted_data.into_vec(), vec![1, 2, 3]); | ||
/// ``` | ||
#[derive(PartialEq, Eq, Debug)] | ||
pub enum OurPeerStorage { | ||
/// Contains ciphertext for transmission. | ||
EncryptedPeerStorage { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Let's drop |
||
/// Stores ciphertext. | ||
cipher: Vec<u8>, | ||
}, | ||
/// Contains serialised decrypted peer storage backup. | ||
DecryptedPeerStorage { | ||
/// Stores decrypted serialised data. | ||
data: Vec<u8>, | ||
}, | ||
} | ||
|
||
impl OurPeerStorage { | ||
/// Return [`OurPeerStorage::EncryptedPeerStorage`] or [`OurPeerStorage::DecryptedPeerStorage`] | ||
/// in [`Vec<u8>`] form. | ||
pub fn into_vec(self) -> Vec<u8> { | ||
match self { | ||
OurPeerStorage::DecryptedPeerStorage { data } => data, | ||
OurPeerStorage::EncryptedPeerStorage { cipher } => cipher, | ||
} | ||
} | ||
|
||
/// Returns [`OurPeerStorage::EncryptedPeerStorage`] with encrypted `cipher`. | ||
/// | ||
/// This function takes a `key` (for encryption) and random_bytes (to derive nonce for encryption) | ||
/// and returns a [`OurPeerStorage::EncryptedPeerStorage`] with encrypted data inside. | ||
/// It should only be called on [`OurPeerStorage::DecryptedPeerStorage`] otherwise it would panic. | ||
/// | ||
/// The resulting serialised data is intended to be directly used for transmission to the peers. | ||
pub fn encrypt_peer_storage( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, by maintaining this unified API, you're losing the benefit of tracking the two variants in the first place. I wonder if it wouldn't make more sense to create two |
||
self, key: &PeerStorageKey, random_bytes: [u8; 32], | ||
) -> OurPeerStorage { | ||
match self { | ||
OurPeerStorage::DecryptedPeerStorage { mut data } => { | ||
let plaintext_len = data.len(); | ||
let nonce = derive_nonce(key, &random_bytes); | ||
|
||
let mut chacha = ChaCha20Poly1305RFC::new(&key.inner, &nonce, b""); | ||
let mut tag = [0; 16]; | ||
chacha.encrypt_full_message_in_place(&mut data[0..plaintext_len], &mut tag); | ||
|
||
data.extend_from_slice(&tag); | ||
|
||
// Prepend `random_bytes` in front of the encrypted_blob. | ||
data.splice(0..0, random_bytes); | ||
Self::EncryptedPeerStorage { cipher: data } | ||
}, | ||
OurPeerStorage::EncryptedPeerStorage { cipher: _ } => { | ||
panic!("Expected OurPeerStorage::DecryptedPeerStorage!"); | ||
}, | ||
} | ||
} | ||
|
||
/// This expects a [`OurPeerStorage::EncryptedPeerStorage`] which would be consumed | ||
/// to return a [`OurPeerStorage::DecryptedPeerStorage`] in case of successful decryption. | ||
/// | ||
/// It would return error if the ciphertext inside [`OurPeerStorage::EncryptedPeerStorage`] is | ||
/// not correct and panic if it is called on [`OurPeerStorage::DecryptedPeerStorage`]. | ||
pub fn decrypt_peer_storage(self, key: &PeerStorageKey) -> Result<Self, ()> { | ||
match self { | ||
OurPeerStorage::EncryptedPeerStorage { mut cipher } => { | ||
let cyphertext_len = cipher.len(); | ||
|
||
// Ciphertext is of the form: random_bytes(32 bytes) + encrypted_data + tag(16 bytes). | ||
let (data_mut, tag) = cipher.split_at_mut(cyphertext_len - 16); | ||
let (random_bytes, encrypted_data) = data_mut.split_at_mut(32); | ||
|
||
let nonce = derive_nonce(key, random_bytes); | ||
|
||
let mut chacha = ChaCha20Poly1305RFC::new(&key.inner, &nonce, b""); | ||
|
||
if chacha.check_decrypt_in_place(encrypted_data, tag).is_err() { | ||
return Err(()); | ||
} | ||
|
||
cipher.truncate(cyphertext_len - 16); | ||
cipher.drain(0..32); | ||
|
||
Ok(Self::DecryptedPeerStorage { data: cipher }) | ||
}, | ||
OurPeerStorage::DecryptedPeerStorage { data: _ } => { | ||
panic!("Expected OurPeerStorage::EncryptedPeerStorage!"); | ||
}, | ||
} | ||
} | ||
} | ||
|
||
/// Nonce for encryption and decryption: Hmac(Sha256(key) + random_bytes). | ||
fn derive_nonce(key: &PeerStorageKey, random_bytes: &[u8]) -> [u8; 12] { | ||
let key_hash = Sha256::const_hash(&key.inner); | ||
|
||
let mut hmac = HmacEngine::<Sha256>::new(key_hash.as_byte_array()); | ||
hmac.input(&random_bytes); | ||
let mut nonce = [0u8; 12]; | ||
// First 4 bytes of the nonce should be 0. | ||
nonce[4..].copy_from_slice(&Hmac::from_engine(hmac).to_byte_array()[0..8]); | ||
|
||
nonce | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use crate::ln::our_peer_storage::{derive_nonce, OurPeerStorage}; | ||
use crate::sign::PeerStorageKey; | ||
|
||
#[test] | ||
fn test_peer_storage_encryption_decryption() { | ||
let key1 = PeerStorageKey { inner: [0u8; 32] }; | ||
let key2 = PeerStorageKey { inner: [1u8; 32] }; | ||
let random_bytes1 = [200; 32]; | ||
let random_bytes2 = [201; 32]; | ||
|
||
// Happy Path | ||
let decrypted_ops = OurPeerStorage::DecryptedPeerStorage { data: vec![42u8; 32] }; | ||
let decrypted_ops_res = decrypted_ops | ||
.encrypt_peer_storage(&key1, random_bytes1) | ||
.decrypt_peer_storage(&key1) | ||
.unwrap(); | ||
assert_eq!(decrypted_ops_res.into_vec(), vec![42u8; 32]); | ||
|
||
// Changing Key | ||
let decrypted_ops_wrong_key = OurPeerStorage::DecryptedPeerStorage { data: vec![42u8; 32] }; | ||
let decrypted_ops_wrong_key_res = decrypted_ops_wrong_key | ||
.encrypt_peer_storage(&key2, random_bytes2) | ||
.decrypt_peer_storage(&key1); | ||
assert!(decrypted_ops_wrong_key_res.is_err()); | ||
|
||
// Nonce derivation happy path | ||
let nonce = derive_nonce(&key1, &random_bytes1); | ||
let nonce_happy_path = derive_nonce(&key1, &random_bytes1); | ||
assert_eq!(nonce, nonce_happy_path); | ||
|
||
// Nonce derivation with different `random_bytes` & `key` | ||
let nonce_diff_random_bytes = derive_nonce(&key1, &random_bytes2); | ||
let nonce_diff_key = derive_nonce(&key2, &random_bytes1); | ||
let nonce_diff_key_random_bytes = derive_nonce(&key2, &random_bytes2); | ||
assert_ne!(nonce, nonce_diff_random_bytes); | ||
assert_ne!(nonce, nonce_diff_key); | ||
assert_ne!(nonce, nonce_diff_key_random_bytes); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can drop this line.