Decay liquidity history buckets appropriately #2530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e448686 changed the procedure to calling update_history_buckets such that the last_updated time may have had been modified already. Thus, the history buckets were not actually decayed inside calls to update_history_buckets. Fix this by separating buckets decaying from updating.
|
This unfortunately needs a rebase. |
|
Yup, also I'm not positive it works in the case where the the liquidity balance is not updated. We'd be adding a datapoint to the history buckets, but to un-decayed data without modifying |
|
Alternatively fixed by #2656 |
|
#2656 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e448686 changed the procedure to calling
update_history_bucketssuch that thelast_updatedtime may have had been modified already. Thus, the history buckets were not actually decayed inside calls toupdate_history_buckets. Fix this by separating buckets decaying from updating.