Refactor unified_qr.rs to use bitcoin-payment-instructions #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

chuksys wants to merge 9 commits into lightningdevkit:main from chuksys:refactor/adopt-bitcoin-payment-instructions

chuksys commented Oct 16, 2025 •

edited

Loading

This PR is a continuation of #607 which was closed mistakenly when the develop base branch was deleted.

This PR introduces a unified.rs module (which is a refactor of the unified_qr.rs module) - this refactor allows us to use this module as a single API for sending payments to BIP 21/321 URIs as well as BIP 353 HRNs, creating a simpler interface for users.

https://github.com/rust-bitcoin/bitcoin-payment-instructions is used to parse BIP 21/321 URIs as well as the BIP 353 HRNs.

Changes

The unified_qr.rs module has been renamed to unified.rs.
The UnifiedQrPayment struct has been renamed to UnifiedPayment.
The QRPaymentResult enum has been renamed to UnifiedPaymentResult.
The send method in unified.rs now supports sending to both BIP 21/321 URIs as well as BIP 353 HRNs.
The integration tests for the module have been updated accordingly.

This PR closes #521

chuksys added 9 commits

October 16, 2025 13:40


          Rename unified_qr to unified

b16c311

This rename reflects that this module is a unified payment interface for both QR code payments and HRN payments passed in as a string without scanning a QR code


          rename UnifiedQRPayment to UnifiedPayment, rename QRPaymentResult to …

7b56717

…UnifiedPaymentResult

These renamings are necessary to reflect the expanded responsibilities for this module.


          add bitcoin-payment-instructions to cargo.toml

6dd41e2


          Add hrn_resolver to Node and pass into UnifiedPayment

7a41664

This commit adds a HRN Resolver to the Node struct which will be useful for resolving HRNs when making BIP 353 payments. It also passes the HRN Resolver into UnifiedPayment.


          Refactor unified.rs to support sending to BIP 21 URIs as well as BIP …

2489eae

…353 HRNs


          Fix typo in unified_payment send test and improve test name.

72454ad


          Switch to explicit imports in unified.rs mod tests

ed2afda


          Use the pay_for_offer_from_hrn method from LDK upstream

2c8c06b

This commit ensures that when using the unified API to send to a HRN, we use pay_for_offer_from_hrn


          Fix formatting issues after rebase

a6dab4e

ldk-reviews-bot commented Oct 16, 2025 •

edited

Loading

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot requested a review from tnull

October 16, 2025 14:09

ldk-reviews-bot commented Oct 18, 2025

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 20, 2025

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

chuksys mentioned this pull request

BOLT 12 / BIP 353 reez/Monday#205

Open

ldk-reviews-bot commented Oct 22, 2025

🔔 3rd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 25, 2025

🔔 4th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 27, 2025

🔔 5th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet