fix: handle disconnected streams on codegen download #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #394
Switch over to axios, which gets the disconnected signals. And use
stream.pipeline
which adds error handling to the stream automatically (otherwise it's adding event handlers forerror
andaborted
on the response data, andclose
on the writer for resolving successfully).This just logs the error currently, on disconnected streams. Looks like this
Would make sense to wrap in some retries.