fix: enable codegen with new annotation #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvlugter
commented
Jun 28, 2022
| @@ -42,6 +42,7 @@ object DescriptorSet { | |||
| Using[FileInputStream, Either[CannotOpen, Iterable[Either[ReadFailure, Descriptors.FileDescriptor]]]]( | |||
| new FileInputStream(file)) { fis => | |||
| val registry = ExtensionRegistry.newInstance() | |||
| registry.add(kalix.Annotations.codegen) | |||
There was a problem hiding this comment.
Was just missing this registration. Model building already added.
johanandren
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #235. Allow the new codegen annotation to be used (just missing extension registration). There are no tests for this yet, but currently trying it out in updated quickstarts.