Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on sbt 1.8.1 to allow for CI on Java 17 #756

Closed
wants to merge 4 commits into from

Conversation

ennru
Copy link
Member

@ennru ennru commented Jan 27, 2022

Trying to update sbt for JDK 17 compatibility.

@ennru
Copy link
Member Author

ennru commented Jan 27, 2022

I had to disable both JaCoCo and Checkstyle as the build wouldn't work immediately. Given that we don't expect this library to evolve more, I believe that could be acceptable. WDYT @havocp ?

@ennru ennru marked this pull request as ready for review January 27, 2022 14:15
@ennru ennru mentioned this pull request Jan 27, 2022
@ennru ennru force-pushed the ennru-sbt-1.6 branch 2 times, most recently from 8495b5d to 301d947 Compare January 27, 2022 14:26
@havocp
Copy link
Collaborator

havocp commented Jan 27, 2022

It seems fine to me as long while nobody's actively working on the library, someone could always put it back if they planned to do a round of work. (Side note there is considerable demand for a couple months of bugfixes and small features I think, judging by the issue tracker, but I don't personally have time to triage it all and do the work right now.)

@ennru
Copy link
Member Author

ennru commented Jan 27, 2022

We can leave this hanging as a reminder to make it work again. The important bit is that it shows -- as expected -- that we don't have any issues with JDK 17.
I created #757 to finish the move to GitHub actions.

@ennru ennru changed the title build on sbt 1.6.1 build on sbt 1.8.1 to allow for CI on Java 17 Jan 5, 2023
@ennru
Copy link
Member Author

ennru commented Jul 6, 2023

We do not intend to extend the functionality of "Typesafe Config" further.
See https://github.com/lightbend/config#maintained-by

@ennru ennru closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants