Inherit optional and getter evaluation #661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radist-nt
reviewed
Apr 27, 2020
config/src/main/java/com/typesafe/config/impl/ConfigBeanImpl.java
Outdated
Show resolved
Hide resolved
radist-nt
reviewed
May 16, 2020
config/src/main/java/com/typesafe/config/impl/ConfigBeanImpl.java
Outdated
Show resolved
Hide resolved
|
We do not intend to extend the functionality of "Typesafe Config" further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added @inherited to @optional and an extra evaluation for the presence of @optional at getter if the field exists. All tests passing but maybe someone can give me a hint where I can implement an extra test for my changes if necessary.
I signed the Lightbend CLA.
closes #659