Custom llvm for lifting bits #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be easier to do like what we did for the pasta patches (if this is similar). Here is the diff when pasta was removed https://github.com/lifting-bits/cxx-common/pull/1032/files#diff-e94885e5f3a6770684c1fd3040f6a9acb4367499c95783aca05b62e96a6ea54e |
|
I dont think it should be so bad to share the cmake for the port and just have the ref point to a different repo? Imo it's easier dev wise to point to our custom repo rather than maintaining patches |
|
Regardless for now im just going to trigger CI to make a release for this custom port (without merging) in order to get something out the door we can use |
Ninja3047
reviewed
Nov 29, 2023
Ninja3047
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP should really share more between versions