LPD-67607 Add exposed function for listing releases #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-chu
force-pushed
the
LPD-67607
branch
from
1558340 to
69f0bb0
Compare
drewbrokke
requested changes
Oct 27, 2025
There was a problem hiding this comment.
@anthony-chu we will also need to fix the lecd function in the shell-source.sh file, since an extra argument is now required.
drewbrokke
requested changes
Oct 29, 2025
scripts/cli/lec.sh
Outdated
| local closest_resource | ||
| local resource="${1}" | ||
|
|
||
| if [[ ${resource} == "" ]]; then |
There was a problem hiding this comment.
2 things here:
- Variable expansion should generally be quoted to avoid word splitting:
if [[ "${resource}" == "" ]]; then- Using
-zis more concise than comparing to an empty string:
if [[ -z "${resource}" ]]; then
scripts/cli/lec.sh
Outdated
| fi | ||
| fi | ||
|
|
||
| _print_step "Listing all ${resource//_/ }" |
There was a problem hiding this comment.
With this change, lecd will now show the output of _print_step as a selectable option. Let's just leave this off so that anything listed here can be used for scripting if desired.
anthony-chu
force-pushed
the
LPD-67607
branch
from
0618959 to
cb99dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-67607