Skip to content

Conversation

@limaagabriel
Copy link
Member

@limaagabriel limaagabriel commented Oct 24, 2025

Ticket: https://liferay.atlassian.net/browse/LPD-69705

This change updates the .storybook/preview.js file to use the SCSS files directly instead of the CSS files. It allows the storybook dev server to watch SCSS files and update it live, allowing for faster SCSS adjustments.

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clayui.com Ready Ready Preview Comment Nov 4, 2025 5:03pm
storybook.clayui.com Ready Ready Preview Comment Nov 4, 2025 5:03pm

Copy link
Member

@pat270 pat270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@limaagabriel I think the watch feature would work better if we ran yarn workspace @clayui/css run build inside clay/.storybook/ instead of having to run it in a separate window. I'm not too familiar with the Storybook API so you will need to reference https://storybook.js.org/docs.

@bryceosterhaus
Copy link
Member

Hey @limaagabriel! This is a good functionality to add for developer experience. Instead of a full separate script, have you tried just replacing the storybook config to point to the scss source instead of the build css file?

For example, in ./storybook/preview.js, replace the first line with import '@clayui/css/src/scss/atlas.scss';

Let me know if that would work

@limaagabriel
Copy link
Member Author

Thanks, @bryceosterhaus! Sounds a great idea, I'll try it today.

@limaagabriel limaagabriel changed the title chore(@clayui/css): LPD-69705 Add watch script chore(storybook): LPD-69705 Enable Storybook reloading on SCSS changes Nov 4, 2025
@limaagabriel
Copy link
Member Author

@bryceosterhaus it works! Changing SCSS files now updates the storybook live.

@limaagabriel limaagabriel requested a review from pat270 November 4, 2025 17:06
@pat270 pat270 merged commit d2bdfcc into liferay:master Nov 4, 2025
5 checks passed
@limaagabriel limaagabriel deleted the LPD-69705 branch November 5, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants