-
Notifications
You must be signed in to change notification settings - Fork 515
chore(storybook): LPD-69705 Enable Storybook reloading on SCSS changes #6197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pat270
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@limaagabriel I think the watch feature would work better if we ran yarn workspace @clayui/css run build inside clay/.storybook/ instead of having to run it in a separate window. I'm not too familiar with the Storybook API so you will need to reference https://storybook.js.org/docs.
|
Hey @limaagabriel! This is a good functionality to add for developer experience. Instead of a full separate script, have you tried just replacing the storybook config to point to the scss source instead of the build css file? For example, in Let me know if that would work |
|
Thanks, @bryceosterhaus! Sounds a great idea, I'll try it today. |
…s to allow reloading upon SCSS changes
b038b1b to
56ecad7
Compare
|
@bryceosterhaus it works! Changing SCSS files now updates the storybook live. |
Ticket: https://liferay.atlassian.net/browse/LPD-69705
This change updates the
.storybook/preview.jsfile to use the SCSS files directly instead of the CSS files. It allows the storybook dev server to watch SCSS files and update it live, allowing for faster SCSS adjustments.