Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote 2025-01-28: script and tests are ready for review #332

Open
wants to merge 10 commits into
base: feat/next-vote
Choose a base branch
from

Conversation

ColdRainbow
Copy link

No description provided.

@ColdRainbow ColdRainbow requested a review from a team as a code owner January 20, 2025 18:10
@ColdRainbow ColdRainbow changed the title Vote 2025-01-28: script is ready for review, tests are in progress Vote 2025-01-28: script and tests are ready for review Jan 20, 2025
configs/config_mainnet.py Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/vote_2025_01_28.py Show resolved Hide resolved
@@ -1,4 +1,5 @@
from brownie import reverts # type: ignore
from brownie import reverts # type: ignore
from typing import Dict, Tuple, List, NamedTuple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change really needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, accidentally deleted the line and then didn't checkout it. Fix is coming

tests/test_vote_2025_01_28.py Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/test_vote_2025_01_28.py Outdated Show resolved Hide resolved
tests/test_vote_2025_01_28.py Outdated Show resolved Hide resolved
tests/test_vote_2025_01_28.py Outdated Show resolved Hide resolved
from utils.agent import agent_forward

description = """
1. **Transition Community Staking Module to Permissionless Phase** by activating public release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using new lines here AFAIK

),
),
(
"3. Increase the stake share limit from 1% to 2% and the priority exit threshold from 1.25 to 2.5 on CS Module",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.25% to 2.5%?


# events
display_voting_events(vote_tx)
evs = group_voting_events(vote_tx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate events?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants