Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight improvement in visibility and fetching events with batches #323

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

loga4
Copy link
Contributor

@loga4 loga4 commented Nov 26, 2024

When running the tests/regression/test_permissions.py test, I ran into a problem that some RPCs cannot give more than 100000 blocks.

FAILED tests/regression/test_permissions.py::test_protocol_permissions - ValueError: {'code': -32602, 'message': 'query exceeds max block range 100000'}

This PR allows fetching blocks in batches + adds progressbar for visibility.

Screen Recording Nov 26 2024

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except only for an explicit dependency addition

tests/regression/test_permissions.py Show resolved Hide resolved
@loga4 loga4 requested review from bulbozaur and zuzueeka November 26, 2024 10:56
@TheDZhon TheDZhon merged commit 0aa3f1a into master Nov 29, 2024
1 check failed
@TheDZhon TheDZhon deleted the chore/batches-progressbar branch November 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants