Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ensuring Compatibility with Ethereum’s Pectra Upgrade #70

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

avsetsin
Copy link

No description provided.

@avsetsin avsetsin force-pushed the feat/pectra-compatibility-proposal branch from 91c0528 to 38f7b66 Compare January 21, 2025 12:24
LIPS/lip-27.md Outdated
```python
def predict_withdrawals_number_in_sweep_cycle(state: BeaconState) -> int:
"""
This method predicts the number of withdrawals that can be performed in a single sweep cycle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This method predicts the number of withdrawals that can be performed in a single sweep cycle.
This method predicts the number of withdrawals that can be performed in a next sweep cycle.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

LIPS/lip-27.md Outdated
For the off-chain components of the Accounting, Validator Exit Bus, and CSM oracles, it is proposed to:

- Implement the switch to the new report collection algorithm at the time of the hardfork activation;
- Account for Eth1 bridge deposits in the `pending_deposits` queue at the time of the hardfork activation;
Copy link
Member

@F4ever F4ever Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Account for Eth1 bridge deposits in the `pending_deposits` queue at the time of the hardfork activation;
- Account for Eth1 bridge deposits in the `pending_deposits` queue at the transition time after hardfork;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

LIPS/lip-27.md Outdated

#### Overview

New versions of the off-chain oracles are proposed, featuring updated algorithms for the Accounting, Validator Exit Bus, and CSM oracles to ensure compatibility with changes introduced by the Pectra hardfork. To minimize disruption, the implementation will include both the current and the updated algorithms, with the latter activated after the Pectra hardfork goes live on the network.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are no minimizing disruption, but trying to avoid any

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants