feat: critical alerts by modules - 4 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Alertmanager failed to handle the numeric `nos_module_id` label correctly. Because of this fact, Discord alerts with this label were not sent and the app returned the Alertmanager error. Now this bug is fixed. 2. The app failed to work correctly with the latest version of the Alertmanager. Now the particular version of the Alertmanager is fixed in the `docker-compose` file so that the app can always start all its containers correctly. 3. Increase memory required for the Prometheus service in the docker-compose, so that the Prometheus service can correctly handle a larger number of node operators. 4. Remove the `DISCORD_WEBHOOK_URL` env variable from env examples as we don't have such a variable in the EVM app. 5. Slightly harmonize the content of alert labels.
This reverts commit 3e71867.
vgorkavenko
reviewed
Jan 23, 2025
1. Replace the `any` type in the `AlertRequestBody` interface fields with more specific types. 2. Fix the maximal version of the Alertmanager that is compatible with the current critical alerts code in the `docker-compose`.
|
Update.
|
vgorkavenko
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes from the PR #264 plus
Alertmanager failed to handle the numeric nos_module_id label correctly. Because of this fact, Discord alerts with this label were not sent and the app returned the Alertmanager error. Now this bug is fixed.
The app failed to work correctly with the latest version of the Alertmanager. Now the particular version of the Alertmanager is fixed in the docker-compose file so that the app can always start all its containers correctly.
Increase memory required for the Prometheus service in the docker-compose, so that the Prometheus service can correctly handle a larger number of node operators.
Remove the DISCORD_WEBHOOK_URL env variable from env examples as we don't have such a variable in the EVM app.
Slightly harmonize the content of alert labels.