Simple DVT Release #225
Merged
Simple DVT Release #225
+2,707
−1,151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
… and external app ports
Chore/update grafana
Colfax23 cs/fix/http port
[Holesky] New WFs
Pull Request #202 introduced a bug with port variables substitution in the `docker-compose.yml` file. Because of this bug clickhouse was not running correctly in a docker container. Now this bug is fixed.
As the Altair epoch is different in different testnets, it is not possible to set a static pre-defined number of the `START_EPOCH` as a required minimum value of this variable. So, for now, we skip the validation of this env variable on testnets. Later it would be better to implement a custom validation directive for validating the minimum possible value of the `START_EPOCH` variable depending on the testnet where the application is running.
As stated in Readme, `HTTP_PORT` environment variable should be optional and have a reasonable default value. But in the previous version of `docker-compose` file it was assumed that the `HTTP_PORT` value must be set. Now this assumption is eliminated and default values for `HTTP_PORT` and `EXTERNAL_HTTP_PORT` environment variables are set in `docker-compose.yml`.
Remove checking that prevents validation of the `START_EPOCH` environment variable value in the test environment. So, now the validation rules for this variable become stronger.
fix: skip validation of `START_EPOCH` env variable
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…r-compose fix: incorrect ports in `docker-compose`
Update `@lido-nestjs` packages to the latest version to support the Holesky testnet.
build(deps): bump @lido-nestjs packages
Temporarily increase the `max-old-space-size` param to 8192 to test Holesky deployment
fix: temporarily increase space size
As stated in `README.md`, some environmental variable values are optional and so can be omitted in the `.env` config file. But these variables didn't have default values in the `docker-compose.yml` config file, so, it was not possible to omit these values when the app was built using Docker. Now default values are added for all optional env variables in the `docker-compose.yml`.
Add empty lines between different sections of the sample `.env` file to improve its readability.
Slightly change comments formatting to improve config readability.
1. Add all environmental variables that are used by the app to the `docker-compose.yml`. Add default values for these variables. 2. Add information about acceptable environmental variables values to the Readme. Add the new "Values" section for each env variable that has a pre-defined set of possible values. 3. Move additional information about environmental variables to the "Note" section in Readme. 4. Add information about the `NODE_ENV` environmental variable to the Readme. 5. Add information about default environmental variable values to the Readme where it was missing. 6. Fix minor issues in Readme. Rephrase some sentences. 7. Add the appropriate Chain ID for the Holesky testnet in the `Network` enum.
1. Add documentation for environmental variables that are used when `VALIDATOR_REGISTRY_SOURCE` variable is set to "keysapi". 2. Add all environmental variables related to Keys API to `docker-compose.yml`. Add default values for these variables.
1. Use `prettier` to format all source code files. 2. Move important .env variables to the top of the `environment` section of `docker-compose`.
chore: empty lines in sample env file
fix: add default env values in docker-compose
# Conflicts: # README.md # docker-compose.yml
Previously the "Earned" parameter in the "Total summary" table of the "Rewards & Penalties" dashboard was calculated incorrectly. It was calculated as `rewards + penalty`, but actually it should be `rewards - penalty`. Now this bug is fixed and the "Earned" column displays correct values.
fix: incorrect calculation in "Earned" column
fix: metric_relabel_configs
…l/traverse-7.23.2 chore(deps): bump @babel/traverse from 7.22.5 to 7.23.2
vgorkavenko
approved these changes
Dec 11, 2023
Pull recent version bump and changelog from the `main` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release of latest improvements in the scope of the big Simple DVT release.