Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additions and Updates to Specification and NatSpec #246

Merged
merged 13 commits into from
Dec 25, 2024
Merged

Additions and Updates to Specification and NatSpec #246

merged 13 commits into from
Dec 25, 2024

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Dec 23, 2024

No description provided.

sandstone-ag
sandstone-ag approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a huge update in the docs. Great work, thank you!
I found some minor (possible) issues (see the comments below). IMO it's not a big deal and can be addressed in the next PR.

contracts/DualGovernance.sol Outdated Show resolved Hide resolved
docs/specification.md Outdated Show resolved Hide resolved
docs/known-risks-and-limitations.md Outdated Show resolved Hide resolved
docs/known-risks-and-limitations.md Outdated Show resolved Hide resolved
@Psirex Psirex merged commit 833e083 into develop Dec 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandstone-ag sandstone-ag sandstone-ag approved these changes

@bulbozaur bulbozaur bulbozaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Psirex @bulbozaur @sandstone-ag