Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor errors naming to follow convention #230

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Dec 6, 2024

No description provided.

Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider changing test names for consistency.

test/unit/Escrow.t.sol Outdated Show resolved Hide resolved
test/unit/Escrow.t.sol Outdated Show resolved Hide resolved
test/unit/Escrow.t.sol Outdated Show resolved Hide resolved
test/unit/Escrow.t.sol Outdated Show resolved Hide resolved
test/unit/Escrow.t.sol Outdated Show resolved Hide resolved
test/unit/Escrow.t.sol Outdated Show resolved Hide resolved
@sandstone-ag sandstone-ag force-pushed the refactor/error-names-improvements branch from a3799ea to e0e266a Compare December 6, 2024 17:11
@Psirex Psirex merged commit 13736dd into develop Dec 6, 2024
2 checks passed
@bulbozaur bulbozaur deleted the refactor/error-names-improvements branch December 6, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants